Skip to content

Conversation

@kassens
Copy link
Member

@kassens kassens commented Aug 5, 2024

This is enabled everywhere for a while and I don't think we'd be backing this out of 19. Seems like it's good to clean up to me.

This is enabled everywhere for a while and I don't think we'd be backing this out of 19. Seems like it's good to clean up to me.
@vercel
Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 3:12pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 5, 2024
@react-sizebot
Copy link

Comparing: c0ee8e94b049a8fb19dd3606a5a1cecc0cbc6a1b...9591111617f63a09d3b74c8ea68c8aacb5400760

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.16% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.40 kB 595.24 kB = 105.60 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.70 kB 571.54 kB = 101.80 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js +0.23% 299.54 kB 300.23 kB +0.17% 53.25 kB 53.34 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.23% 299.54 kB 300.23 kB +0.17% 53.25 kB 53.34 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.23% 299.61 kB 300.29 kB +0.17% 53.27 kB 53.36 kB

Generated by 🚫 dangerJS against 2dddcba

@kassens kassens merged commit 6590358 into facebook:main Aug 5, 2024
@kassens kassens deleted the pr30595 branch August 5, 2024 15:25
github-actions bot pushed a commit that referenced this pull request Aug 5, 2024
This is enabled everywhere for a while and I don't think we'd be backing
this out of 19. Seems like it's good to clean up to me.

DiffTrain build for [6590358](6590358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants