[Flight] Enable Binary and ReadableStreams in Stable #29035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
May 9, 2024
| @@ -72,8 +72,8 @@ export const renameElementSymbol = false; | |||
| export const enableCache = true; | |||
| export const enableLegacyCache = true; | |||
|
|
|||
| export const enableBinaryFlight = false; | |||
| export const enableFlightReadableStream = false; | |||
There was a problem hiding this comment.
Since HaaS doesn't support binary data in the stream itself, it'd need something in the stream to encode it as a string but it's not really different from how an SSR implementation has to deal with it.
|
The size diff is too large to display in a single comment. The CircleCI job contains an artifact called 'sizebot-message.md' with the full message. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are ready to ship in stable.