Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make enableRefAsProp www dynamic #28423

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Make enableRefAsProp www dynamic #28423

merged 1 commit into from
Feb 22, 2024

Conversation

rickhanlonii
Copy link
Member

Going to start rolling this out

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 22, 2024
kassens
kassens approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rickhanlonii

@react-sizebot
Copy link

Comparing: e4b816b...fb722cf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.86 kB 176.86 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.01 kB 179.01 kB = 55.78 kB 55.78 kB
facebook-www/ReactDOM-prod.classic.js +0.10% 591.79 kB 592.40 kB +0.16% 104.51 kB 104.67 kB
facebook-www/ReactDOM-prod.modern.js +0.10% 575.08 kB 575.68 kB +0.15% 101.51 kB 101.66 kB
facebook-www/JSXDEVRuntime-dev.modern.js +6.78% 47.96 kB 51.22 kB +5.96% 12.63 kB 13.38 kB
facebook-www/JSXDEVRuntime-dev.classic.js +6.78% 47.97 kB 51.22 kB +5.97% 12.63 kB 13.38 kB
facebook-www/ReactServer-dev.modern.js +3.64% 91.47 kB 94.80 kB +3.11% 21.75 kB 22.43 kB
facebook-www/ReactServer-prod.modern.js +2.80% 16.08 kB 16.54 kB +3.17% 4.20 kB 4.34 kB
facebook-www/React-dev.modern.js +2.73% 121.76 kB 125.09 kB +2.33% 29.05 kB 29.73 kB
facebook-www/React-dev.classic.js +2.70% 123.34 kB 126.67 kB +2.31% 29.44 kB 30.12 kB
facebook-www/React-prod.modern.js +2.06% 19.94 kB 20.35 kB +2.23% 4.99 kB 5.10 kB
facebook-www/React-prod.classic.js +2.03% 20.23 kB 20.64 kB +2.30% 5.05 kB 5.17 kB
facebook-www/React-profiling.modern.js +2.01% 20.37 kB 20.78 kB +2.17% 5.07 kB 5.18 kB
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/JSXDEVRuntime-dev.modern.js +6.78% 47.96 kB 51.22 kB +5.96% 12.63 kB 13.38 kB
facebook-www/JSXDEVRuntime-dev.classic.js +6.78% 47.97 kB 51.22 kB +5.97% 12.63 kB 13.38 kB
facebook-www/ReactServer-dev.modern.js +3.64% 91.47 kB 94.80 kB +3.11% 21.75 kB 22.43 kB
facebook-www/ReactServer-prod.modern.js +2.80% 16.08 kB 16.54 kB +3.17% 4.20 kB 4.34 kB
facebook-www/React-dev.modern.js +2.73% 121.76 kB 125.09 kB +2.33% 29.05 kB 29.73 kB
facebook-www/React-dev.classic.js +2.70% 123.34 kB 126.67 kB +2.31% 29.44 kB 30.12 kB
facebook-www/React-prod.modern.js +2.06% 19.94 kB 20.35 kB +2.23% 4.99 kB 5.10 kB
facebook-www/React-prod.classic.js +2.03% 20.23 kB 20.64 kB +2.30% 5.05 kB 5.17 kB
facebook-www/React-profiling.modern.js +2.01% 20.37 kB 20.78 kB +2.17% 5.07 kB 5.18 kB
facebook-www/React-profiling.classic.js +1.98% 20.66 kB 21.07 kB +2.22% 5.13 kB 5.25 kB
facebook-www/ReactFlightDOMClient-dev.modern.js +1.44% 39.58 kB 40.14 kB +1.20% 9.17 kB 9.28 kB
facebook-www/ReactFlightDOMServer-prod.modern.js +0.76% 38.86 kB 39.15 kB +0.55% 8.84 kB 8.89 kB
facebook-www/ReactDOMServer-prod.classic.js +0.49% 204.91 kB 205.92 kB +0.36% 37.22 kB 37.35 kB
facebook-www/ReactFlightDOMServer-dev.modern.js +0.48% 100.05 kB 100.53 kB +0.75% 20.82 kB 20.97 kB
facebook-www/ReactDOMServer-prod.modern.js +0.30% 203.75 kB 204.36 kB +0.29% 36.95 kB 37.06 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.30% 207.61 kB 208.22 kB +0.29% 38.32 kB 38.43 kB
facebook-www/ReactART-dev.modern.js +0.24% 1,051.64 kB 1,054.15 kB +0.37% 206.42 kB 207.20 kB
facebook-www/ReactART-dev.classic.js +0.24% 1,063.85 kB 1,066.35 kB +0.37% 208.84 kB 209.61 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.20% 484.53 kB 485.51 kB +0.31% 98.27 kB 98.57 kB
facebook-www/ReactDOMServer-dev.modern.js +0.20% 491.76 kB 492.74 kB +0.31% 99.87 kB 100.19 kB
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Generated by 🚫 dangerJS against fb722cf

@rickhanlonii rickhanlonii merged commit aaf85f3 into main Feb 22, 2024
37 checks passed
@rickhanlonii rickhanlonii deleted the rh/ref-flag branch February 22, 2024 20:35
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
@rickhanlonii
Make enableRefAsProp www dynamic (#28423)
ec5b61a 
Going to start rolling this out

DiffTrain build for [aaf85f3](aaf85f3)
@huozhi huozhi mentioned this pull request Feb 26, 2024
Merged
huozhi added a commit to vercel/next.js that referenced this pull request Feb 26, 2024
@huozhi
Upgrade vendored react (#62549)
87015ac 
### React upstream changes

- facebook/react#28438
- facebook/react#28436
- facebook/react#25954
- facebook/react#28434
- facebook/react#28433
- facebook/react#28432
- facebook/react#28415
- facebook/react#27903
- facebook/react#28430
- facebook/react#28424
- facebook/react#28400
- facebook/react#28422
- facebook/react#28423
- facebook/react#28412
- facebook/react#28418
- facebook/react#28421
- facebook/react#28417
- facebook/react#28399
- facebook/react#28408
- facebook/react#28350
- facebook/react#28387
- facebook/react#28403
- facebook/react#28384
- facebook/react#28409
- facebook/react#28398
- facebook/react#28405
- facebook/react#28328
- facebook/react#28402
- facebook/react#28386
- facebook/react#28388
- facebook/react#28379
- facebook/react#28383
- facebook/react#28390
- facebook/react#28389
- facebook/react#28382
- facebook/react#28348



Closes NEXT-2600
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
Make enableRefAsProp www dynamic (facebook#28423)
b13caa1 
Going to start rolling this out
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@rickhanlonii
Make enableRefAsProp www dynamic (#28423)
c97ec71 
Going to start rolling this out

DiffTrain build for commit aaf85f3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickhanlonii @react-sizebot @kassens @facebook-github-bot