fix invalid link to react-devtools-extensions/src/__tests__ #25816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved to react-devtools-shared.
eps1lon
approved these changes
Dec 6, 2022
| @@ -65,7 +65,7 @@ yarn build:chrome && yarn test:chrome --url=<url-to-test> | |||
| ``` | |||
|
|
|||
| # Unit tests | |||
| Core DevTools functionality is typically unit tested (see [here](https://github.com/facebook/react/tree/main/packages/react-devtools-shared/src/__tests__) and [here](https://github.com/facebook/react/tree/main/packages/react-devtools-extensions/src/__tests__)). To run tests, you'll first need to build or download React and React DOM ([as explained above](#build-react-and-react-dom)) and then use the following NPM script: | |||
There was a problem hiding this comment.
Removed tests were moved to shared in #22260 so it's fine to simply delete
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
DiffTrain build for `7db45b9a38b8d1b5b945756cf38a174c1ec6118a`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the invalid link which points to react-devtools-extensions/src/_tests_ in
CONTRIBUTING.md, as it's already moved to react-devtools-shared/src/_tests_ in #22260.How did you test this change?
By run
yarn testandyarn lint.