Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Dec 5, 2022

Instead of the current commit message (which just shows "Build for
", re-use the commit message from the origin commit instead.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 5, 2022
@poteto poteto changed the title [DiffTrain] Use commit message [DiffTrain] Use original commit message Dec 5, 2022
@sizebot
Copy link

sizebot commented Dec 5, 2022

Comparing: f0534ae...11de1bf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.40 kB 154.40 kB = 49.00 kB 49.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.32 kB 156.32 kB = 49.65 kB 49.65 kB
facebook-www/ReactDOM-prod.classic.js = 533.40 kB 533.40 kB = 94.99 kB 94.99 kB
facebook-www/ReactDOM-prod.modern.js = 518.50 kB 518.50 kB = 92.80 kB 92.80 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.40 kB 533.40 kB = 94.99 kB 94.99 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 11de1bf

Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@poteto poteto force-pushed the lt/difftrain-title branch from 59c2f19 to 483fe57 Compare December 5, 2022 18:17
@poteto
Copy link
Member Author

poteto commented Dec 5, 2022

Example of it working: db7a745

@poteto
Copy link
Member Author

poteto commented Dec 5, 2022

Actually I just realized that the SHA is the long one in the commit message, GitHub just uses the short version in its UI. I think I'll append the SHA to the end of the commit message instead so the title isn't super long when we import it.

@poteto poteto force-pushed the lt/difftrain-title branch 2 times, most recently from ae879d1 to 4b8a837 Compare December 5, 2022 18:25
Instead of the current commit message (which just shows "Build for
<sha>", re-use the commit message from the origin commit instead. This
also appends the SHA to the end of the commit message instead of
prefixing it.
@poteto poteto force-pushed the lt/difftrain-title branch from 4b8a837 to 11de1bf Compare December 5, 2022 18:46
@poteto poteto merged commit cd23e40 into main Dec 5, 2022
@poteto poteto deleted the lt/difftrain-title branch December 5, 2022 18:57
github-actions bot pushed a commit that referenced this pull request Dec 5, 2022
Instead of the current commit message (which just shows "Build for
<sha>", re-use the commit message from the origin commit instead.

DiffTrain build for `cd23e40c734d758726419c0a3bd91576211bd83f`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants