Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow upgrade to 0.153 #25412

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Flow upgrade to 0.153 #25412

merged 1 commit into from
Oct 4, 2022

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • method unbinding is no longer supported in Flow for soundness, this added a bunch of suppressions
  • Flow now prevents objects to be supertypes of interfaces/classes

@kassens
Flow upgrade to 0.153
05ea2a4 
- method unbinding is no longer supported in Flow for soundness, this added a bunch of suppressions
- Flow now prevents objects to be supertypes of interfaces/classes

[ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
@kassens kassens mentioned this pull request Oct 4, 2022
Merged
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Oct 4, 2022
kassens added a commit to kassens/react that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.153
8cceffa 
- method unbinding is no longer supported in Flow for soundness, this added a bunch of suppressions
- Flow now prevents objects to be supertypes of interfaces/classes

ghstack-source-id: d7749cbad8050874fa14d533442f110ad1d0209d
Pull Request resolved: facebook#25412
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 64fe791...05ea2a4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +1.57% 4.70 kB 4.77 kB +2.00% 1.70 kB 1.73 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +1.57% 4.70 kB 4.77 kB +2.00% 1.70 kB 1.73 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-node-register.js +1.57% 4.70 kB 4.77 kB +2.00% 1.70 kB 1.73 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.45% 52.38 kB 52.62 kB +0.27% 13.18 kB 13.21 kB
oss-experimental/react-cache/cjs/react-cache.development.js +0.44% 8.67 kB 8.71 kB +0.48% 2.94 kB 2.95 kB
oss-stable-semver/react-cache/cjs/react-cache.development.js +0.44% 8.67 kB 8.71 kB +0.48% 2.94 kB 2.95 kB
oss-stable/react-cache/cjs/react-cache.development.js +0.44% 8.67 kB 8.71 kB +0.48% 2.94 kB 2.95 kB
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js +0.43% 46.05 kB 46.25 kB +0.23% 11.78 kB 11.80 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.42% 9.51 kB 9.55 kB +0.53% 3.00 kB 3.02 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.42% 9.51 kB 9.55 kB +0.53% 3.00 kB 3.02 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-plugin.js +0.42% 9.51 kB 9.55 kB +0.53% 3.00 kB 3.02 kB
facebook-www/ReactFlightDOMRelayServer-dev.classic.js +0.41% 64.60 kB 64.87 kB +0.24% 16.60 kB 16.64 kB
facebook-www/ReactFlightDOMRelayServer-dev.modern.js +0.41% 64.65 kB 64.92 kB +0.24% 16.61 kB 16.65 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.35% 48.51 kB 48.68 kB +0.20% 12.20 kB 12.22 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.35% 48.51 kB 48.68 kB +0.20% 12.20 kB 12.22 kB
oss-experimental/jest-react/cjs/jest-react.development.js +0.34% 10.61 kB 10.65 kB +0.48% 3.75 kB 3.76 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js +0.34% 10.61 kB 10.65 kB +0.48% 3.75 kB 3.76 kB
oss-stable/jest-react/cjs/jest-react.development.js +0.34% 10.61 kB 10.65 kB +0.48% 3.75 kB 3.76 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.33% 81.31 kB 81.58 kB +0.25% 21.05 kB 21.10 kB
oss-experimental/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.33% 85.37 kB 85.65 kB +0.26% 21.31 kB 21.36 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.29% 82.77 kB 83.01 kB +0.18% 21.19 kB 21.23 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.26% 77.38 kB 77.59 kB +0.17% 20.08 kB 20.12 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.browser.development.server.js +0.26% 77.38 kB 77.59 kB +0.17% 20.08 kB 20.12 kB
oss-stable-semver/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.26% 81.25 kB 81.46 kB +0.18% 20.32 kB 20.36 kB
oss-stable/react-server-dom-webpack/umd/react-server-dom-webpack-writer.browser.development.server.js +0.26% 81.25 kB 81.46 kB +0.18% 20.32 kB 20.36 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.21% 78.85 kB 79.02 kB +0.10% 20.22 kB 20.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-writer.node.development.server.js +0.21% 78.85 kB 79.02 kB +0.10% 20.22 kB 20.24 kB

Generated by 🚫 dangerJS against 05ea2a4

@kassens kassens merged commit 05ea2a4 into gh/kassens/2/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
@kassens
Flow upgrade to 0.153
9f8a98a 
- method unbinding is no longer supported in Flow for soundness, this added a bunch of suppressions
- Flow now prevents objects to be supertypes of interfaces/classes

ghstack-source-id: d7749cbad8050874fa14d533442f110ad1d0209d
Pull Request resolved: #25412
@kassens kassens deleted the gh/kassens/2/head branch October 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @sizebot @gaearon @facebook-github-bot