Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools: Fix typo from directores to directories #25124

Merged
merged 1 commit into from
Aug 22, 2022
Merged

devtools: Fix typo from directores to directories #25124

merged 1 commit into from
Aug 22, 2022

Conversation

taiga39
Copy link
Contributor

@taiga39 taiga39 commented Aug 21, 2022 •
edited
Loading

The Overview documents had a small typo.

  • packages/react-devtools-core/README.md

@facebook-github-bot
Copy link

Hi @taiga39!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@taiga39 taiga39 marked this pull request as ready for review August 21, 2022 15:12
@taiga39
Copy link
Contributor Author

taiga39 commented Aug 22, 2022

The changes from the first commit have been merged.
3e0aa88
↓
#25100

@taiga39 taiga39 changed the title Fix some typos Fix one typo Aug 22, 2022
@taiga39 taiga39 changed the title Fix one typo Fix typo directores to directories Aug 22, 2022
@taiga39 taiga39 changed the title Fix typo directores to directories Fix typo from directores to directories Aug 22, 2022
@eps1lon eps1lon changed the title Fix typo from directores to directories devtools: Fix typo from directores to directories Aug 22, 2022
eps1lon
eps1lon approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit e25648b into facebook:main Aug 22, 2022
@taiga39 taiga39 deleted the fix-type-in-md branch August 22, 2022 19:21
GrinZero added a commit to GrinZero/react that referenced this pull request Aug 31, 2022
@GrinZero
Merge branch 'main' of ssh://github.com/GrinZero/react
ca0bdeb 
* 'main' of ssh://github.com/GrinZero/react: (26 commits)
  [devtools][easy] Fix flow type (facebook#25147)
  Remove Symbol Polyfill (again) (facebook#25144)
  Remove ReactFiberFlags MountLayoutDev and MountPassiveDev (facebook#25091)
  experimental_use(promise) (facebook#25084)
  [Transition Tracing] onMarkerIncomplete - Tracing Marker/Suspense Boundary Deletions (facebook#24885)
  [Flight] Add support for Webpack Async Modules (facebook#25138)
  Fix typo: supportsMicrotask -> supportsMicrotasks (facebook#25142)
  Allow functions to be used as module references (facebook#25137)
  Test the node-register hooks in unit tests (facebook#25132)
  Return closestInstance in `getInspectorDataForViewAtPoint` (facebook#25118)
  [DevTools] Highlight RN elements on hover (facebook#25106)
  Update fixtures/flight to webpack 5 (facebook#25115)
  Align StrictMode behaviour with production (facebook#25049)
  Scaffolding for useMemoCache hook (facebook#25123)
  devtools: Fix typo from directores to directories (facebook#25124)
  fixture: Fix typo from perfomrance to performance (facebook#25100)
  [DevTools] Add events necessary for click to inspect on RN (facebook#25111)
  Add missing createServerContext for experimental shared subset (facebook#25114)
  support subresource integrity for bootstrapScripts and bootstrapModules (facebook#25104)
  make preamble and postamble types explicit and fix typo (facebook#25102)
  ...
rickhanlonii pushed a commit that referenced this pull request Oct 6, 2022
@taiga39 @rickhanlonii
devtools: Fix typo from directores to directories (#25124)
21520d3
@Toywitme12
Copy link

Toywitme12 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taiga39 @facebook-github-bot @Toywitme12 @eps1lon