Add RN_FB bundles for react-is #23101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 9a7e6bf...79aff1b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rickhanlonii
approved these changes
Jan 12, 2022
|
why do we want to use it? i think whenever we look at use cases for it, there are usually better approaches that don't involve introspecting types. |
|
@gaearon This isn't for any new use cases (that I'm aware of) - it's strictly for using a single version that is in sync with our build of React at existing call sites (mostly in third-party packages, but a handful in first-party code) that are currently relying pretty arbitrarily on a mix of |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 19, 2022
Summary: This sync includes the following changes: - **[51947a14b](facebook/react@51947a14b )**: Refactored how React/DevTools log Timeline performance data ([#23102](facebook/react#23102)) //<Brian Vaughn>// - **[c09596cc6](facebook/react@c09596cc6 )**: Add RN_FB bundles for react-is ([#23101](facebook/react#23101)) //<Moti Zilberman>// - **[9a7e6bf0d](facebook/react@9a7e6bf0d )**: Add --no-show-signature to "git show" commands ([#23038](facebook/react#23038)) //<Stefan Sundin>// - **[2f26eb85d](facebook/react@2f26eb85d )**: Add exports field to react-refresh's package.json ([#23087](facebook/react#23087)) //<Gray Zhang>// - **[811634762](facebook/react@811634762 )**: add enableTransitionTracing feature flag ([#23079](facebook/react#23079)) //<Luna Ruan>// Changelog: [General][Changed] - React Native sync for revisions fe905f1...51947a1 jest_e2e[run_all_tests] Reviewed By: rickhanlonii, kacieb Differential Revision: D33634332 fbshipit-source-id: a83b663a122a2cb79225ca33a007fe1774728c03
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* Add RN_FB bundles for react-is * Update packaging.js * Add ReactNativeInternalFeatureFlags to externals
nevilm-lt
pushed a commit
to nevilm-lt/react
that referenced
this pull request
Apr 22, 2022
* Add RN_FB bundles for react-is * Update packaging.js * Add ReactNativeInternalFeatureFlags to externals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
react-isbuild artifacts for use with React Native within Meta.How did you test this change?