Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Log version in internal logger #22825

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

jstejada
Copy link
Contributor

Summary

Log the version in our internal logger.

How did you test this change?

  • yarn flow
  • yarn test-build-devtools
  • version is logged correctly

image

@jstejada jstejada merged commit a65ceef into facebook:main Nov 30, 2021
@jstejada jstejada deleted the log-version branch December 1, 2021 17:15
@@ -25,6 +25,7 @@ export function registerDevToolsEventLogger(surface: string) {
event: event,
context: {
surface,
version: process.env.DEVTOOLS_VERSION,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍🏼

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants