Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fizz exported types #21596

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Fix Fizz exported types #21596

merged 1 commit into from
Jun 1, 2021

Conversation

sebmarkbage
Copy link
Collaborator

I noticed that this was missing while writing docs. These aren't tested since our tests don't use Flow. I also noticed we don't use exact objects by default which would've caught this oversight.

@sebmarkbage sebmarkbage requested a review from gaearon June 1, 2021 16:51
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 1, 2021
@sizebot
Copy link

sizebot commented Jun 1, 2021

Comparing: 28625c6...c72e5ed

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.15 kB 406.15 kB = 75.12 kB 75.12 kB
facebook-www/ReactDOM-prod.modern.js = 394.52 kB 394.52 kB = 73.31 kB 73.30 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.15 kB 406.15 kB = 75.13 kB 75.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c72e5ed

@sebmarkbage sebmarkbage merged commit 8f6163c into facebook:master Jun 1, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants