Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-for-devtools script to prepare unit tests too #21182

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 5, 2021

Recent changes to split build and build2 directories broke the development/testing work flow used for DevTools, which builds only a small subset of the React packages to run tests locally. This PR temporarily fixes that breakage by copying files from build to build2.

@bvaughn bvaughn requested review from rickhanlonii and acdlite April 5, 2021 20:40
@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Apr 5, 2021
@sizebot
Copy link

sizebot commented Apr 5, 2021

Comparing: a817840...0a38dde

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.62 kB 122.62 kB = 39.34 kB 39.34 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.18 kB 129.18 kB = 41.42 kB 41.42 kB
facebook-www/ReactDOM-prod.classic.js = 405.84 kB 405.84 kB = 75.37 kB 75.37 kB
facebook-www/ReactDOM-prod.modern.js = 394.10 kB 394.10 kB = 73.51 kB 73.50 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.84 kB 405.84 kB = 75.37 kB 75.37 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0a38dde

@bvaughn bvaughn merged commit d778518 into facebook:master Apr 6, 2021
@bvaughn bvaughn deleted the devtools-build-scripts branch April 6, 2021 13:24
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 11, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 13, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 19, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants