Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspectRatio to the unitless list #21100

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Add aspectRatio to the unitless list #21100

merged 1 commit into from
Mar 25, 2021

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 25, 2021

Fixes #21098.
Done via GH.

Test plan: let's see if sandbox works.

@gaearon gaearon requested a review from sebmarkbage March 25, 2021 16:25
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 25, 2021
@gaearon gaearon mentioned this pull request Mar 25, 2021
Closed
@sizebot
Copy link

sizebot commented Mar 25, 2021

Comparing: 05ec0d7...0956f8a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.01% 122.51 kB 122.53 kB +0.02% 39.47 kB 39.48 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.01% 128.92 kB 128.94 kB +0.02% 41.48 kB 41.49 kB
facebook-www/ReactDOM-prod.classic.js = 406.91 kB 406.93 kB +0.01% 75.54 kB 75.55 kB
facebook-www/ReactDOM-prod.modern.js = 395.17 kB 395.19 kB +0.01% 73.62 kB 73.63 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.91 kB 406.93 kB +0.01% 75.54 kB 75.55 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0956f8a

@gaearon gaearon merged commit a7c5726 into master Mar 25, 2021
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 11, 2021
@gaearon @acdlite
Add aspectRatio to the unitless list (facebook#21100)
7a3d0f0
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 13, 2021
@gaearon @acdlite
Add aspectRatio to the unitless list (facebook#21100)
061136e
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
@gaearon @acdlite
Add aspectRatio to the unitless list (facebook#21100)
4f10b0e
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 16, 2021
@gaearon @acdlite
Add aspectRatio to the unitless list (facebook#21100)
eac4111
acdlite pushed a commit to acdlite/react that referenced this pull request Apr 19, 2021
@gaearon @acdlite
Add aspectRatio to the unitless list (facebook#21100)
a9db018
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
@gaearon @koto
Add aspectRatio to the unitless list (facebook#21100)
cc498c2
@gaearon gaearon mentioned this pull request Mar 29, 2022
Merged
@kassens kassens deleted the gaearon-patch-14 branch November 29, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: aspectRatio not being applied via style
4 participants
@gaearon @sizebot @sebmarkbage @facebook-github-bot