-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entangled expired lanes with SyncLane #21083
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -682,28 +682,14 @@ describe('ReactExpiration', () => { | |
updateHighPri(); | ||
|
||
// Both normal pri updates should have expired. | ||
if (gate(flags => flags.FIXME)) { | ||
// The sync update and the expired normal pri updates render in a | ||
// single batch. | ||
expect(Scheduler).toHaveYielded([ | ||
'Sibling', | ||
'High pri: 1', | ||
'Normal pri: 2', | ||
'Sibling', | ||
]); | ||
} else { | ||
expect(Scheduler).toHaveYielded([ | ||
'Sibling', | ||
'High pri: 0', | ||
'Normal pri: 2', | ||
'Sibling', | ||
// TODO: This is the sync update. We should have rendered it in the same | ||
// batch as the expired update. | ||
'High pri: 1', | ||
'Normal pri: 2', | ||
'Sibling', | ||
]); | ||
} | ||
// The sync update and the expired normal pri updates render in a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the "normal pri" important here? Aren't we rendering the sync update and any expired updates? If so, should there be tests for the other cases? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The "expired" part of "expired normal pri" is the important part |
||
// single batch. | ||
expect(Scheduler).toHaveYielded([ | ||
'Sibling', | ||
'High pri: 1', | ||
'Normal pri: 2', | ||
'Sibling', | ||
]); | ||
}); | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the added check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't have to check for NoLanes inside markRootExpired