Don't use nested objects to "namespace" namespace constants #21073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
approved these changes
Mar 24, 2021
|
looks like you missed some. |
sebmarkbage
force-pushed
the
domnamespaces
branch
from
c4d3fd5
to
d510162
Compare
|
Comparing: 7b84dbd...d510162 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
commented
Mar 24, 2021
| namespace = getIntrinsicNamespace(tag); | ||
| } | ||
|
|
||
| if (__DEV__) { | ||
| if (namespace === Namespaces.html) { | ||
| if (namespace === HTML_NAMESPACE) { |
There was a problem hiding this comment.
So this is really weird. We track the namespace in prod and the only thing we use it for is this warning.
We don't need the namespace on the server since it's implied by the HTML.
There was a problem hiding this comment.
Looks like it was intentional. #10452
But I'm just going to remove this because it's not worth the overhead/complexity when we don't bother with this on the client anyway.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if closure is smart enough but as a pattern we don't gamble.