Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[failing] Add failing test for serialization errors not being caught by inner boundary #20218

Closed

Conversation

sebmarkbage
Copy link
Collaborator

Follow up to #20217

We can't actually fix this easily without giving up the benefit of using native JSON.stringify, or adding support for lazy references inside of React DOM attributes.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3b74744:

Sandbox Source
React Configuration

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Nov 11, 2020
@sizebot
Copy link

sizebot commented Nov 11, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 3b74744

@sizebot
Copy link

sizebot commented Nov 11, 2020

Warnings
⚠️ Could not find build artifacts for base commit: 16e6dad

Size changes (stable)

Generated by 🚫 dangerJS against 3b74744

@sebmarkbage
Copy link
Collaborator Author

This only really happens for functions. (It happens for symbols too, but only if they're not from Symbol.for. It happens for bigint but we can fix that.)

One question is whether we should just relax this to a DEV error and instead pass undefined to these props.

@facebook-github-bot
Copy link

Hi @sebmarkbage!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sebmarkbage sebmarkbage deleted the branch facebook:master October 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants