Run DevTools tests against npm releases#19377
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 83b14f1:
|
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
force-pushed
the
devtools-release-test
branch
4 times, most recently
from
849ae4e to
4c3ec92
Compare
Adds a CircleCI job that runs the DevTools tests against a given version of React.
acdlite
force-pushed
the
devtools-release-test
branch
from
4c3ec92 to
3a51d49
Compare
|
@bvaughn This works but the tests don't actually pass. Some of them are implementation details, though, and I'm not sure how important they are. Maybe before landing this, I can set up the |
|
Or I could land this now and make it so it's not push blocking. I was thinking we'd want to do that anyway so we don't slow down unrelated PRs. We can run it on a cron schedule instead. |
acdlite
force-pushed
the
devtools-release-test
branch
from
3a51d49 to
83b14f1
Compare
Yeah, gating by version number seems really helpful for this.
This also sounds fine. |
| dep.startsWith('.') || | ||
| // Don't replace React isomorphic package, since the backend may use | ||
| // component types/features that don't exist in an older version | ||
| dep === 'react' |
There was a problem hiding this comment.
Will we hit any snags with earlier 16.x react-dom versions and later 16.x react versions?
| const version = process.argv[2]; | ||
|
|
||
| async function main() { | ||
| await exec('mkdir build-tmp'); |
There was a problem hiding this comment.
We should probably have some cleanup for if this script fails midway (it does for me at the moment, and it leaves a build-tmp dir which causes it to fail next run)
| - run: | ||
| name: Download a specific version of React + renderers | ||
| command: node scripts/jest/install-devtools-release-test-deps.js << parameters.version >> | ||
| - run: yarn test --project=devtools --build --ci |
There was a problem hiding this comment.
yarn_test_release_devtools:
docker: *docker
environment: *environment
parameters:
version:
type: string
default: next
steps:
- checkout
- attach_workspace: *attach_workspace
- *restore_yarn_cache
- *run_yarn
- run:
name: Download a specific version of React + renderers
command: node scripts/jest/install-devtools-release-test-deps.js << parameters.version >>
- run: yarn test --project=devtools --build --ci
5 participants
WIP
Adds a CircleCI job that runs the DevTools tests against a given version of React.