[eslint-plugin-react-hooks]: handling empty element in array

[yeonjuan]

…lback

Summary

"eslint-plugin-reack-hooks" throw Error when listing "useEffect" if there are empty elements in the array. I added checking whether the element is null or not.

• code

useEffect(foo, [, foo]);

• error

TypeError: Cannot read property 'type' of null
Occurred while lining .../tests/test.ts:1
    at /Users/.../eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:838:23
    at Array.some (<anonymous>)

Test Plan

function MyComponent({myEffect}) {
    useEffect(myEffect, [,myEffect]);
}

function MyComponent({myEffect}) {
     useEffect(myEffect, [,myEffect,,]);
}

[facebook-github-bot]

Hi @yeonjuan!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a34865:

Sandbox	Source
competent-moore-3h7jj	Configuration

[sizebot]

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 0a34865

[sizebot]

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 0a34865

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[bvaughn]

Looks good to me.