Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useMutableSource tearing bug #18912

Merged
merged 2 commits into from
May 13, 2020
Merged

Fix useMutableSource tearing bug #18912

merged 2 commits into from
May 13, 2020

Commits on May 13, 2020

  1. Failing useMutableSource test 

    If a source is mutated after initial read but before subscription is set
up, it should still entangle all pending mutations even if snapshot of
new subscription happens to match.

Test case illustrates how not doing this can lead to tearing.
    @acdlite
    acdlite committed May 13, 2020
    Configuration menu
    Copy the full SHA
    43ce30b View commit details
    Browse the repository at this point in the history

  2. Fix useMutableSource tearing bug 

    Fix is to move the entanglement call outside of the block that checks
if the snapshot has changed.
    @acdlite
    acdlite committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c3c4c3f View commit details
    Browse the repository at this point in the history