Add Relay Flight Build #18242
Merged
Add Relay Flight Build #18242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with react-server. Currently this just includes flight but it could be expanded to include the whole reconciler.
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb97e8e:
|
Details of bundled changes.Comparing: 7a1691c...cb97e8e react-flight-dom-relay
react-client
Size changes (stable) |
Details of bundled changes.Comparing: 7a1691c...cb97e8e react-flight-dom-relay
react-client
Size changes (experimental) |
This will be the config specifically for streaming purposes. There will be other configs for other purposes.
gaearon
approved these changes
Mar 7, 2020
sthagen
added a commit
to sthagen/facebook-react
that referenced
this pull request
Mar 7, 2020
Add Relay Flight Build (facebook#18242)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to host a Flight Server and Flight Client inside Relay. Currently, there's only an FB www build because I'm not sure how we'll want to sync it to the OSS repo yet. Most likely it'll end up being an RN build instead since RN is Relay's source of truth.
We'll need another host config option for this configuration so I added
dom-relayfor that.This is currently encoding to a JSON array of strings but I'll refactor to a different format/layering in a follow up.
Renamed some flight files while I was at it.