Modern Event System: add plugin handling and forked paths #18195
+368
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
necolas,
philipp-spiess,
gaearon,
lunaruan and
acdlite
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4cd1e11:
|
threepointone
approved these changes
Mar 3, 2020
| // which also nicely allows us to support more without needing | ||
| // to add more individual code paths to support various | ||
| // events that do not bubble. | ||
| expect(handleImgLoadStart).toHaveBeenCalledTimes(1); |
packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js
Outdated
Show resolved
Hide resolved
trueadm
force-pushed
the
modern-event-tests
branch
2 times, most recently
from
d63d2f6
to
54be398
Compare
Fix Fix Fix
trueadm
force-pushed
the
modern-event-tests
branch
from
54be398
to
4cd1e11
Compare
sthagen
added a commit
to sthagen/facebook-react
that referenced
this pull request
Mar 3, 2020
Modern Event System: add plugin handling and forked paths (facebook#18195)
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Merged
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more of the modern event system logic, enough that based single root/non-portal logic now works and removing the flag should result in most tests passing. Note: this PR does not affect the existing legacy event system, and the only real changes are to the new modern event system (which is behind a flag anyway). This PR consists of:
DOMModernPluginEventSystem.jsadds event plugin handling, which is basically the exact same code from the legacy event system (except refactored to use basic for loops)DOMModernPluginEventSystem-test.internal.jsthat showes basic capture/bubble events working correctly with the new system (on a single root/non-portal example)ReactBrowserEventEmitter-test.internal.jsuses the correct existing depending on the modern event system flagReactDOMEventListener-test.jsdisables or alters the expected outcome when using the new systemReactTreeTraversal-test.jsdisables or alters the expected outcome when using the new systemEnterLeaveEventPlugin.jsalters the logic to account for the new event system having roots rather than a single document listener, plus disables the first ancestor logic for the modern event system.