More event system cleanup and scaffolding #18179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
sebmarkbage,
necolas,
philipp-spiess,
gaearon and
acdlite
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64dc9a4:
|
Details of bundled changes.Comparing: 4ee592e...64dc9a4 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 4ee592e...64dc9a4 react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
threepointone
approved these changes
Feb 28, 2020
Fix Address feedback Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step towards adding a forked modern event system that uses roots. Before we get to that stage, we need to do some cleanup and add some parts of the scaffolding.
Specifically, this PR does the following:
ensureListeningToto accept modern/legacy eventslegacyTrapBubbledEventcalls in a flag, as we won't do these in the modern event system (we use the capture phase instead).dispatchEventForLegacyPluginEventSystemcalls atDOMEventListenerbehind the flag, as the entrance point for dispatching modern event system events.listenToTopLevelEventcalls atReactDOMEventReplayingbehind the flag, as the entrance point for replaying modern event system events.DOMModernPluginEventSystemmodule. This doesn't do much for now, the rest of the code and tests will come in a follow up PR. It does register events accordingly however.Note: there should be no functional changes to the existing legacy event system.