-
Notifications
You must be signed in to change notification settings - Fork 46.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Root API callback params and added warnings #17916
Removed Root API callback params and added warnings #17916
Conversation
7d1fed5
to
b64acb1
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d1fed5:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b64acb1:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, might want to bikeshed the warning message later. Don't have any specific suggestion though.
Cool. Happy to tweak it later. |
The goal is to prevent introducing new uses of the update queue callback behavior (so that we can deprecate it later, as part of cleaning up legacy class component usage), Fortunately it looks like we weren't using these params internally anywhere, so I've just added tests that verify the new warning behavior.
I based the wording of this warning on a similar warning for hooks:
react/packages/react-reconciler/src/ReactFiberHooks.js
Lines 1265 to 1278 in cf00812