Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Event testing library improvements #17614

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Dec 15, 2019

Introduces a state machine around pointer events to produce more accurate mock
touch events. This allows multi-touch unit tests to be written entirely in
terms of mock pointer interactions, while producing the expected
'changedTouches', 'targetTouches', and 'touches' fields for mock touch events.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 15, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5dcc3bd:

Sandbox Source
gracious-wiles-oob25 Configuration

@necolas
Copy link
Contributor Author

necolas commented Dec 16, 2019

After we merge this I was thinking of moving it to packages/dom-event-testing-library and adding unit tests to catch regressions. Then I can also add it to the eslint excludes for the production logging rule.

@necolas necolas force-pushed the react-interactions/testing-library branch from 29c8b64 to e06bdd2 Compare December 16, 2019 10:58
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like how clean it is with these changes. :)

@necolas necolas force-pushed the react-interactions/testing-library branch 2 times, most recently from fd69c3f to 6e18505 Compare December 16, 2019 12:32
@necolas
Copy link
Contributor Author

necolas commented Dec 16, 2019

I'm not going to land this or any other PR to this repo until we get to the bottom of why CI tasks aren't running on my PRs

Introduces a state machine around pointer events to produce more accurate mock
touch events. This allows multi-touch unit tests to be written entirely in
terms of mock pointer interactions, while producing the expected
'changedTouches', 'targetTouches', and 'touches' fields for mock touch events.
@necolas necolas force-pushed the react-interactions/testing-library branch from 6e18505 to 5dcc3bd Compare December 18, 2019 22:13
@sizebot
Copy link

sizebot commented Dec 18, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 5dcc3bd

@necolas necolas merged commit a5e951d into facebook:master Dec 18, 2019
@necolas necolas deleted the react-interactions/testing-library branch December 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants