Added a DevTools store test for component names #17283
Conversation
| } | ||
| } | ||
|
|
||
| let hocs = hocDisplayNames === null ? '' : ` [${hocDisplayNames.join('][')}]`; |
There was a problem hiding this comment.
Serialize the store in a format that includes the HOC badges, more like the Badge component does in the real DevTools UI. This will make our tests more meaningful.
There was a problem hiding this comment.
Yeah this is pretty. Nice.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d9eb1c:
|
1. Add a Store test for memo, lazy, and forwardRef components 2. Remove dead code for React.lazy 3. Update DT tests to include HOC badge names in the serialized store
bvaughn
force-pushed
the
devtools-tests
branch
from
cc35c57
to
8d9eb1c
Compare
|
One question folks, has this been released already? I couldn't find any entry on the tags @bvaughn @threepointone |
|
Why does it matter? This is an update to an internal test. |
You are right, but I will assume that if this PR is not related, then #17274 has not been released either since they are both related. |
|
Pretty sure #17274 is released. |
|
Awesome @gaearon thanks for the quick response 🎉 |
I'm not sure what you mean by this but #17274 is listed in the changelog as being released back in November. |
Follow up to #17274
memo,forwardRef, andlazycomponents.React.lazy.