[Fresh] Prevent local variables from being used in the hook signature

[theKashey]

The current implementation of the babel plugin would move any use* to the hook signature, except the "builtin" hooks.
That could lead to a false positive, when something, which ducks like hook could not be used in the signature.

const Component = ({useTheForce}) => {
  const useInnerHook = () => {useTheForce();};

  useInnerHook();
}

Solution

Check that variable is reachable from the signature scope. That would not let track the "real" hook composition, but, at least, would not lead to runtime error.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[sizebot]

No significant bundle size changes to report.

Generated by 🚫 dangerJS

[theKashey]

The required code was already implemented, just in a bit different form.