-
Notifications
You must be signed in to change notification settings - Fork 46.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React events: ignore device buttons that aren't for primary interactions #15402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React: size: -0.4%, gzip: 🔺+0.4% ReactDOM: size: -1.4%, gzip: -0.8% Details of bundled changes.Comparing: 3438e5c...4563880 react
react-dom
react-art
react-test-renderer
react-noop-renderer
react-reconciler
react-native-renderer
scheduler
react-events
Generated by 🚫 dangerJS |
The Pointer Events spec mentions that the value of `button` in a nativeEvent can be anything between 0 and 5 for "down" events. We only care about those with a value of 0.
3e7f1f8
to
4563880
Compare
trueadm
approved these changes
Apr 12, 2019
threepointone
pushed a commit
to threepointone/react
that referenced
this pull request
Apr 15, 2019
…ons (facebook#15402) The Pointer Events spec mentions that the value of `button` in a nativeEvent can be anything between 0 and 5 for "down" events. We only care about those with a value of 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pointer Events spec mentions that the value of
button
in a nativeEventcan be anything between 0 and 5 for "down" events. We only care about those
with a value of 0.
Ref #15257