Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using the wrong renderer's act() should warn #15398

Closed
wants to merge 7 commits into from
Closed

using the wrong renderer's act() should warn #15398

wants to merge 7 commits into from

Commits on Apr 3, 2019

  1. mark react-events as private so we publish script skips it for now

    Sunil Pai committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    c35e37a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master'

    Sunil Pai committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    dc605c1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master'

    Sunil Pai committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    a09bd0f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. warn when using the wrong act() around create/updates 

    via facebook#15319
This solves 2 specific problems -
- using the 'wrong' act() doesn't silence the warning
- using the wrong act logs a warning

It does this by using an empty object on the reconciler as the identity of ReactShouldWarnActingUpdates.current. We also add this check when calling createContainer() to catch the common failure of this happening right in the beginning.
    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    6aac3a2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into renderer-specific… 

    …-react-should-warn-acting-updates
    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    5a0c7c6 View commit details
    Browse the repository at this point in the history

  3. DEV check for createContainer warnIfNotScopedWithMatchingAct check

    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    5761e3b View commit details
    Browse the repository at this point in the history

  4. ugh prettier

    Sunil Pai committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    8228278 View commit details
    Browse the repository at this point in the history