Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recommended config eslint rule #14762

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Feb 6, 2019

Tested by copying in the built package in a project and following the added instructions in the readme

@sizebot
Copy link

sizebot commented Feb 6, 2019

Fails
🚫

node` failed.

Log

Error:  { FetchError: invalid json response body at http://react.zpao.com/builds/master/_commits/d827445a500e497712a1a404c7ccc25779b1df5c/results.json reason: Unexpected token < in JSON at position 0
    at /home/circleci/project/node_modules/node-fetch/lib/body.js:48:31
    at process._tickCallback (internal/process/next_tick.js:68:7)
  name: 'FetchError',
  message:
   'invalid json response body at http://react.zpao.com/builds/master/_commits/d827445a500e497712a1a404c7ccc25779b1df5c/results.json reason: Unexpected token < in JSON at position 0',
  type: 'invalid-json' }

Generated by 🚫 dangerJS

@edmorley
Copy link

edmorley commented Sep 8, 2019

Thank you for opening a PR for this! I'm presuming the CI failure is an infra issue and unrelated to this change? If so, could someone retrigger CI? :-)

@SimenB
Copy link
Contributor Author

SimenB commented Sep 8, 2019

Rebased this and added the second rule

@sizebot
Copy link

sizebot commented Sep 8, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 65b466d

@stale
Copy link

stale bot commented Jan 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2020
@necolas necolas requested a review from gaearon January 9, 2020 21:57
@stale stale bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2020
@gaearon gaearon merged commit 79a2512 into facebook:master Feb 28, 2020
@gaearon
Copy link
Collaborator

gaearon commented Feb 28, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants