Add directory details to the package.json of all packages #14628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying the directory as part of the `repository` field in a `package.json` allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in npm/rfcs#19.
|
Are we sure this won't break some other tools relying on it being a string? I'd like to see some smaller packages do that first as pilot. |
|
@gaearon - certain, unless they've built something insanely hacky that doesn't support the normal object syntax. The string is just syntactic sugar provided by npm - it gets converted to an object in the API response. See http://registry.npmjs.org/react-dom. |
|
Seems good. Thanks. |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…4628) Specifying the directory as part of the `repository` field in a `package.json` allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in npm/rfcs#19.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…4628) Specifying the directory as part of the `repository` field in a `package.json` allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in npm/rfcs#19.
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Specifying the directory as part of the `repository` field in a `package.json` allows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package. This format was accepted by npm in npm/rfcs#19.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the directory as part of the
repositoryfield in apackage.jsonallows third party tools to provide better support when working with monorepos. For example, it allows them to correctly construct a commit diff for a specific package.This format was accepted by npm in npm/rfcs#19.