Add a failing test for unnecessary commits #13483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
Need to rebase and see if that still reproes. Could be a CM bug that leads to unnecessary work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this demonstrates what I've been running into with my time slicing demo. Not sure though — maybe it's a different problem. If there is a good explanation for this behavior I can dig further.
The symptom I was seeing is that if I flood the scheduler with enough low pri work, it would make a synchronous long chain of commits during expiration — sometimes locking up the thread for 20 seconds or so. I couldn't find a way to reproduce more than one extra commit in this test, but maybe this is enough to demonstrate the issue?