Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render charset instead of charSet on SSR #12789

Closed
wants to merge 1 commit into from
Closed

Render charset instead of charSet on SSR #12789

wants to merge 1 commit into from

Conversation

yhirano55
Copy link

Summary

On SSR, I found the bug that it renders charSet attribute on meta element:

Expected:
"<meta charset=\"utf-8\" data-reactroot=\"\"/>"

Received:
"<meta charSet=\"utf-8\" data-reactroot=\"\"/>"

So I've fixed it.

@yhirano55
Render charset instead of charSet on SSR
ba7f9b0 
Fixed this:

Expected:
  "<meta charset=\"utf-8\" data-reactroot=\"\"/>"
Received:
  "<meta charSet=\"utf-8\" data-reactroot=\"\"/>"
@aweary
Copy link
Contributor

aweary commented May 12, 2018

This has been reported multiple times and is not a bug. Thanks though!

@aweary aweary closed this May 12, 2018
@yhirano55
Copy link
Author

Oh...thanks for the comment. I understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhirano55 @aweary @facebook-github-bot