Skip to content

Allow jsx to write tags with bracket, instead of dot, notation. #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Allow jsx to write tags with bracket, instead of dot, notation. #1240

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f0ef38
Allow jsx to write tags with bracket, instead of dot, notation.
actionnick Mar 10, 2014
fe540ed
Only use bracket notation if tag is invalid.
actionnick Mar 10, 2014
6899fce
Address @spicyj PR comments.
actionnick Mar 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions vendor/fbtransform/transforms/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,13 @@ function visitReactTag(traverse, object, path, state) {
}

var isFallbackTag = FALLBACK_TAGS.hasOwnProperty(nameObject.name);
utils.append(
(isFallbackTag ? jsxObjIdent + '.' : '') + (nameObject.name) + '(',
state
);
var tagOpening;
if (isFallbackTag) {
tagOpening = jsxObjIdent + '["' + (nameObject.name) + '"]' + '('
Copy link
Contributor

@petehunt petehunt Mar 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will break closure compiler minification. I think this would be a good idea if we could detect if it is not a valid JS identifier (ie. contains -) and use this only for invalid identifiers

} else {
tagOpening = nameObject.name + '('
}
utils.append(tagOpening, state);

utils.move(nameObject.range[1], state);

Expand Down