Update test renderer to support new types of work #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for ContextProvider, ContextConsumer, and Mode.
acdlite
commented
Feb 16, 2018
| @@ -366,6 +369,9 @@ function toTree(node: ?Fiber) { | |||
| case HostText: | |||
| return node.stateNode.text; | |||
| case Fragment: | |||
| case ContextProvider: | |||
| case ContextConsumer: | |||
| case Mode: | |||
There was a problem hiding this comment.
I'm treating these as fragments right now because I'm not really sure how this output is consumed. Should I create a new nodeType?
There was a problem hiding this comment.
Seems like nodeType is only used for user-defined components and host components. Everything else is treated as a pass-through.
|
I'm going to merge this so we can unblock some internal teams that are using the new context API. @ljharb and @lelandrichardson let me know if there are additional follow-up items. |
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
Adds support for ContextProvider, ContextConsumer, and Mode.
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Adds support for ContextProvider, ContextConsumer, and Mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ContextProvider, ContextConsumer, and Mode.
Closes #12150