Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplication of warn when selected is set on <option> #11821

Merged
merged 5 commits into from
Dec 10, 2017
Merged

Deduplication of warn when selected is set on <option> #11821

merged 5 commits into from
Dec 10, 2017

Commits on Dec 9, 2017

  1. Deduplication of warn selected on option 

    - Wrote a failing test
- Deduplication when selected is set on option
    @watadarkstar
    watadarkstar committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    be5b2c7 View commit details
    Browse the repository at this point in the history

  2. Ran yarn preitter

    @watadarkstar
    watadarkstar committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    0f1ad41 View commit details
    Browse the repository at this point in the history

  3. Fixed PR request 

    - Moved dedupe test to above
- Moved && case to seperate if to seperate static and dynamic things
- Render'd component twice
    @watadarkstar
    watadarkstar committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    c5137d5 View commit details
    Browse the repository at this point in the history

  4. Actually check for deduplication

    @watadarkstar
    watadarkstar committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    e3b5a2b View commit details
    Browse the repository at this point in the history

  5. Minor nits

    @gaearon
    gaearon authored Dec 9, 2017
    Configuration menu
    Copy the full SHA
    4ebcbfe View commit details
    Browse the repository at this point in the history