Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote ReactIncrementalPerf-test using only public API.(#11299) #11724

Merged
merged 8 commits into from
Nov 30, 2017
Merged

Rewrote ReactIncrementalPerf-test using only public API.(#11299) #11724

merged 8 commits into from
Nov 30, 2017

Conversation

abiduzz420
Copy link
Contributor

Prerequisites

Changes added

  • ReactPortal.js shifted to shared directory
  • Implemented createPortal() method in ReactNoop.js
  • This createPortal() is used to write test for support portals in ReactIncrementalPerf-test.internal.js

Please let me know if I need to make any further modifications or changes.

@abiduzz420
Copy link
Contributor Author

abiduzz420 commented Nov 30, 2017 •
edited
Loading

This PR solves the issue from #11299 in ReactIncrementalPerf-test.internal.js

@gaearon gaearon merged commit f57d963 into facebook:master Nov 30, 2017
@gaearon
Copy link
Collaborator

gaearon commented Nov 30, 2017

Thanks!

@abiduzz420
Copy link
Contributor Author

Thanks @gaearon Dan for helping me out :)

@gaearon gaearon mentioned this pull request Nov 30, 2017
Closed
26 tasks
@SomeshThakur
Copy link

Awesome Work Uzair ! :)

@leimonio
Copy link

leimonio commented Dec 2, 2017

Great job @abiduzz420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abiduzz420 @gaearon @SomeshThakur @leimonio