Remove EventListener fbjs utility #11617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EventListener normalizes event subscription for <= IE8. This is no longer necessary. element.addEventListener is sufficient.
gaearon
reviewed
Nov 22, 2017
| @@ -124,10 +123,10 @@ export function trapBubbledEvent(topLevelType, handlerBaseName, element) { | |||
| if (!element) { | |||
| return null; | |||
| } | |||
| return EventListener.listen( | |||
| element, | |||
| element.addEventListener( | |||
There was a problem hiding this comment.
This is only equivalent if element always has addEventListener. The original code in fbjs checked for it.
Are we 100% certain it always exists?
gaearon
requested changes
Nov 22, 2017
There was a problem hiding this comment.
Turns out I tried this before: #10592 (review). We couldn't do it because we rely on fbjs/lib/EventListener hook being overridden for Facebook.com (we have some custom logic there). I don't think we can easily drop this without coming up with some other solution for us.
|
I have an alternative: #11797 |
|
Superseded by #11797. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventListener normalizes event subscription for <= IE8. This is no longer necessary. element.addEventListener is sufficient.
Follow-up from #11515