Move Mousewheel Event Type Detection to BrowserConstants (#11585) #11594
Conversation
There was a problem hiding this comment.
This is great, I just realized we can be a little more aggressive with removing this compatibility code than I originally thought.
Let's go ahead and drop the fallback checks and just leave the code removal in ReactBrowserEventEmitter.
Thank you for sending this out!
| topWheel: 'wheel', | ||
| topWheel: isEventSupported('wheel') | ||
| ? 'wheel' | ||
| : isEventSupported('mousewheel') ? 'mousewheel' : 'DOMMouseScroll', | ||
| }; |
There was a problem hiding this comment.
Did some quick checks. We have DOMMouseScroll for Firefox, but MDN claims that wheel is supported as of Firefox 17.0. We support the Firefox Extended Support Release (ESR), which is presently at 52.5.0. I think this is a safe change that will not affect any user.
Also it also looks like IE9 supports wheel (though it's not on the window according to MDN, the event is still supported).
So we can drop this check all-together. That would mean we'd revert the changes to this file and just keep the code removal in ReactBrowserEventEmitter.
@aweary, @jquense, or @gaearon any concerns with sending this out in a patch release?
There was a problem hiding this comment.
I don't mind if your test it in the minimal supported browsers.
| // @see http://www.quirksmode.org/dom/events/tests/scroll.html | ||
| trapBubbledEvent('topWheel', 'DOMMouseScroll', mountAt); | ||
| } | ||
| } else if (dependency === 'topScroll') { |
There was a problem hiding this comment.
Tested in:
- Firefox 47, 52, 56
- Chrome 47, 62
- Safari 7.1, 11
- IE 9, 10, 11
- Edge 14, 16
- Opera 18, 49
I tested with a hardware mouse wheel and gesture scrolling on track pads.
Thanks, @cristidrg!
Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html