-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite setInnerHTML tests to use Public API. #11385
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
29821ba
Rewrite setInnerHTML tests to use Public API.
69e7c54
Rename variables and drop unnecessary variable assignments.
53b7b4a
Merge branch 'master' into master
3d73094
Rename testfile to dangerouslySetInnerHTML-test.js
ef5a516
Merge pull request #1 from facebook/master
ad14f12
Properly prettify test file.
1d9641c
Merge branch 'master' of https://github.com/facebook/react
12165eb
Rewrite SVG tests to verify we recover from missing innerHTML
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
72 changes: 72 additions & 0 deletions
72
packages/react-dom/src/client/__tests__/dangerouslySetInnerHTML-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/** | ||
* Copyright (c) 2016-present, Facebook, Inc. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const React = require('react'); | ||
const ReactDOM = require('react-dom'); | ||
|
||
describe('dangerouslySetInnerHTML', () => { | ||
describe('when the node has innerHTML property', () => { | ||
it('sets innerHTML on it', () => { | ||
const container = document.createElement('div'); | ||
const node = ReactDOM.render( | ||
<div dangerouslySetInnerHTML={{__html: '<h1>Hello</h1>'}} />, | ||
container, | ||
); | ||
expect(node.innerHTML).toBe('<h1>Hello</h1>'); | ||
}); | ||
}); | ||
|
||
describe('when the node does not have an innerHTML property', () => { | ||
let container; | ||
beforeEach(() => { | ||
// Create a mock container that looks like a svg in IE (without innerHTML) | ||
container = document.createElementNS('http://www.w3.org/2000/svg', 'svg'); | ||
|
||
spyOn(container, 'appendChild').and.callThrough(); | ||
spyOn(container, 'removeChild').and.callThrough(); | ||
}); | ||
|
||
it('sets innerHTML on it', () => { | ||
const html = '<circle></circle>'; | ||
|
||
ReactDOM.render( | ||
<g dangerouslySetInnerHTML={{__html: html}} />, | ||
container, | ||
); | ||
|
||
expect(container.appendChild.calls.argsFor(0)[0].innerHTML).toBe( | ||
'<circle></circle>', | ||
); | ||
}); | ||
|
||
it('clears previous children', () => { | ||
const firstHtml = '<rect></rect>'; | ||
const secondHtml = '<circle></circle>'; | ||
|
||
ReactDOM.render( | ||
<g dangerouslySetInnerHTML={{__html: firstHtml}} />, | ||
container, | ||
); | ||
ReactDOM.unmountComponentAtNode(container); | ||
ReactDOM.render( | ||
<g dangerouslySetInnerHTML={{__html: secondHtml}} />, | ||
container, | ||
); | ||
|
||
expect(container.removeChild.calls.argsFor(0)[0].innerHTML).toBe( | ||
'<rect></rect>', | ||
); | ||
expect(container.appendChild.calls.argsFor(1)[0].innerHTML).toBe( | ||
'<circle></circle>', | ||
); | ||
}); | ||
}); | ||
}); |
68 changes: 0 additions & 68 deletions
68
packages/react-dom/src/client/__tests__/setInnerHTML-test.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd. Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to defeat the purpose of the test (which is to verify
setInnerHTML
itself cleans up old nodes).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mistakingly testing that unmounting removes a child, and mounting into the same container later adds it.
Instead of testing that inside an already mounted container, operations setting dangerous HTML on SVG node, if it doesn't have
innerHTML
(as in IE11), will useappendChild
/removeChild
.