Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation-notes.md #11135

Closed
wants to merge 1 commit into from
Closed

Conversation

hardfist
Copy link

@hardfist hardfist commented Oct 6, 2017

prevChild could be CompositeComponent instance which cause prevChild.node to be undefined.

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Format your code with prettier (npm run prettier).
  6. Make sure your code lints (npm run lint).
  7. Run the Flow typechecks (npm run flow).
  8. If you haven't already, complete the CLA.

prevChild could be CompositeComponent instance which cause prevChild.node to be undefined.
@reactjs-bot
Copy link

Deploy preview ready!

Built with commit e312865

https://deploy-preview-11135--reactjs.netlify.com

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Hi @hardfist! Thanks so much for contributing to the React documentation.

You may not have been aware of issue #11075 but we were in the process of moving documentation to its own repository. It is now live at a new location: https://github.com/reactjs/reactjs.org

Please re-open this PR there (if you're willing). We apologize for the inconvenience!

Cheers!

@bvaughn bvaughn closed this Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants