Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move docs and examples licenses #10891

Closed
wants to merge 1 commit into from

Conversation

jonricaurte
Copy link

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Format your code with prettier (npm run prettier).
  6. Make sure your code lints (npm run lint).
  7. Run the Flow typechecks (npm run flow).
  8. If you haven't already, complete the CLA.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sophiebits
Copy link
Collaborator

It's better to keep them in the root of the repo for clarity so no one accidentally thinks the main license applies to docs content.

@sophiebits sophiebits closed this Sep 27, 2017
@jonricaurte
Copy link
Author

I see. Was just trying to make it so the MIT License was displayed in the top navigation bar: #10889

@sophiebits
Copy link
Collaborator

Got it. I think it's clearer to keep it this way; if GitHub will only display it if there is one LICENSE then I guess we'll have to do without. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Sep 27, 2017

We could also move docs in a different repo (like many projects do).

@jonricaurte
Copy link
Author

Just wanted to make it less of a headache for you all so it basically shows the GitHub stamp of approval kind of thing especially after seeing all the discussions regarding licenses the past few weeks.

@gaearon
Copy link
Collaborator

gaearon commented Sep 27, 2017

Yea, I agree it would be nice. I'm just not sure we can do it.
It would be nice if GH just let you pick the primary license..

@jonricaurte
Copy link
Author

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants