issues/10085

[wenchaojiang]

Nope, I haven't done linting flow and have not fixed the test.
This is a draft for discussion not for merging.

Before submitting a pull request, please make sure the following is done:

1. Fork the repository and create your branch from master.
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes (npm test).
5. Format your code with prettier (npm run prettier).
6. Make sure your code lints (npm run lint).
7. Run the Flow typechecks (npm run flow).
8. If you haven't already, complete the CLA.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[gaearon]

Sorry we couldn't get to reviewing this yet. We've been in a big rush to get 16 out and couldn't review PRs. I hope we'll get around to this in a few weeks.

[gaearon]

Could you please rebase this on master?

[gaearon]

I'll close this as stale but I hope this PR will be helpful to whoever attempts this next. I think we'll need more higher level discussion about the approach first before writing the code though. Thanks for your work on this!