Add table of attribute behavior #10536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
force-pushed
the
attributebehaviortable
branch
from
ca986fd
to
9d9d2ea
Compare
acdlite
force-pushed
the
attributebehaviortable
branch
from
bc13add
to
41c1871
Compare
|
😮 |
Strings on, off, true, false
|
Should this live in |
|
Probably, I just threw it together. It's pretty messy right now. We're trying to get the simplest, most MVP version complete for the release. |
|
Yea, fair enough, didn’t mean it’s important 😛 |
|
Originally it was going to be a normal node script that printed out a table until we realized that we'd have to special case every single attribute :D |
# Conflicts: # scripts/attribute-behavior/src/App.js
Once we get past MVP stage we can hook this up to the build system so these files are automatically copied over.
acdlite
force-pushed
the
attributebehaviortable
branch
from
1bff114
to
faf6c8e
Compare
Avoid all undefined reads.
Tests different input types and valueAsNumber property. This value is often NaN. To compare that we also need to switch to Object.is.
**what is the change?:** We checked in bundles of React v15 to run comparisons of attribute behavior on DOM elements between 15 and 16. This commit tells prettier and eslint to ignore those files, and fixes a prettier lint in one other file from that fixture. **why make this change?:** To get CI passing. **test plan:** `yarn prettier` doesn't change anything, eslint passes **issue:**
flarnie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many "special cases" of attributes that React may recognize and treat in different ways. For each of these cases, we must consider common mis-capitalizations and alternative formats for the attribute name. For all possible value types, we need to verify that any changes between React 15 and 16 are intentional and understood.
This is an unpolished MVP of a fixture to compare the behavior between React 15 and 16 for every possible value type for each attribute name.
This will be useful for verifying and understanding the changed made in:
2999811
5ba1803
35859df