Add renderer id to react-devtools injection #10475
Conversation
|
I think this is good, thanks. |
|
@gaearon Should we bikeshed the name a bit since we have to live with it forever? |
| @@ -813,6 +813,7 @@ const foundDevTools = injectInternals({ | |||
| // This is an enum because we may add more (e.g. profiler build) | |||
| bundleType: __DEV__ ? 1 : 0, | |||
| version: ReactVersion, | |||
| id: 'react-dom', | |||
There was a problem hiding this comment.
rendererType: 'react-dom'?
There was a problem hiding this comment.
rendererName? rendererUniqueName? People cloning ReactDOM might think a "type" would still be ReactDOM.
There was a problem hiding this comment.
rendererPackageName? As in the npm name.
|
Hey! I changed the name. |
| @@ -813,7 +813,7 @@ const foundDevTools = injectInternals({ | |||
| // This is an enum because we may add more (e.g. profiler build) | |||
| bundleType: __DEV__ ? 1 : 0, | |||
| version: ReactVersion, | |||
| id: 'react-dom', | |||
| rendererPackageName: 'react-dom', | |||
There was a problem hiding this comment.
Could you also please add this to React Native entries?
|
It seems like we don't want to see any renderer duplicated, not About adding to |
|
Can you file another PR for ReactART? I think it doesn't even contain a call now. We should add it. |
|
I'll do that. I'll update the devtools PR as well, detecting not |
|
That sounds great. Thanks! |
Helps to resolve
react-devtools700 — reporting multiplereact-domcopies.I added
idargument to detectreact-domwithout code-guessing.