Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SSR doc #10436

Closed
wants to merge 4 commits into from
Closed

Conversation

aickin
Copy link
Contributor

@aickin aickin commented Aug 11, 2017

This PR consolidates the two SSR reference pages into one page. Since the streaming render methods were recently moved from react-dom/node-stream to react-dom/server, it makes sense to document them in the same place as the other methods on react-dom/server.

I also corrected a factual error in the doc about data-reactid, which is no longer added in React 16.

This is a documentation-only change. Thanks!

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Thank you for filing this PR!

I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants