Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only public API in CSSProperty-test #10429

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Use only public API in CSSProperty-test #10429

merged 3 commits into from
Aug 16, 2017

Conversation

ksvitkovsky
Copy link
Contributor

As a part of #9955

@gaearon
Copy link
Collaborator

gaearon commented Aug 11, 2017

Can we also have a second test that verifies they get correctly set when rendering on the client side with ReactDOM? In fact I think it might be best to remove this file and create a similar test inside ReactDOMServerIntegration-test that verifies these styles end up being set. Because it tests both client and server rendering at the same time.

@ksvitkovsky
Copy link
Contributor Author

ksvitkovsky commented Aug 11, 2017

I'm working on it right now and have that weird issue(?) when rendering element with styles that has ms-prefixed rules. Rendered element' style property has ms-prefixed rules starting with lower-case 'm' in clean client render-scenario, while in others it is upper-case 'M'.

Is that the expected behavior? If so, is that ok to write expectations like this - expect(e.style.MsFlexGrow || e.style.msFlexGrow).toBe('10');

@gaearon
Copy link
Collaborator

gaearon commented Aug 11, 2017

Might be a jsdom bug. Yes, I think this is fine since it depends on jsdom implementation.

@gaearon gaearon merged commit 488e741 into facebook:master Aug 16, 2017
@gaearon
Copy link
Collaborator

gaearon commented Aug 16, 2017

Thanks!

@gaearon gaearon mentioned this pull request Oct 20, 2017
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants