Additional information on PropTypes.func #10301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clarification that PropTypes.func can be used to check for a class components.
|
My apologizes, first pull request. I didn't realize I needed to run tests considering I updated a line in prop-types documentation only. Nothing that tests would run on. Once again sorry, but how should I proceed? |
bvaughn
reviewed
Oct 8, 2017
| @@ -56,6 +56,9 @@ MyComponent.propTypes = { | |||
|
|
|||
| // A React element. | |||
| optionalElement: PropTypes.element, | |||
|
|
|||
| // A function or class | |||
| optionalElement: PropTypes.func | |||
There was a problem hiding this comment.
It's not valid to define the same property twice. Instead use PropTypes.oneOfType([...])
|
Thank you for filing this PR! I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.) Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarification that PropTypes.func can be used to check for a class components.