Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info that PropTypes are also nice as "component API docs" #10282

Closed
wants to merge 1 commit into from

Conversation

kremuwa
Copy link

@kremuwa kremuwa commented Jul 26, 2017

In my opinion, PropTypes have more benefits than just typechecking. In order to better highlight benefits their usage, I have added a (hopefully)concise information about one particular benefit I noticed, which is the fact that they allow developers to see what props can be set on a component in a single place.

In my opinion, PropTypes have more benefits than just typechecking. In order to better highlight benefits their usage, I have added a (hopefully)concise information about one particular benefit I noticed, which is the fact that they allow developers to see what props can be set on a component in a single place.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@kremuwa kremuwa changed the title Added info that PropTypes also excel as "component API docs" Added info that PropTypes are also nice as "component API docs" Jul 26, 2017
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Thank you for filing this PR!

I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly!

@bvaughn bvaughn closed this Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants