Update typechecking-with-proptypes.md

[rscharfer]

improved grammar

Before submitting a pull request, please make sure the following is done:

1. Fork the repository and create your branch from master.
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes (npm test).
5. Format your code with prettier (npm run prettier).
6. Make sure your code lints (npm run lint).
7. Run the Flow typechecks (npm run flow).
8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
9. If you haven't already, complete the CLA.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[nhunzaker]

Nit: what about as of instead of on?

[rscharfer]

Sorry. For a second there I was imagining "React v15.5" was a date. So, for example, "React.PropTypes" was moved into a different package on Dec, 13 2016" would have been correct.

Looking at it again, I think we could incorporate your as of and say React.PropTypes is in a different package as of React v15.5 or as of React v15.5, React.PropTypes is in a different package or even since React v15.5, React.PropTypes is in a different package. But 'has moved' and 'since' don't work together unless it has been moving to the new package this entire time.

[nhunzaker]

I like how "React.PropTypes was moved into a different package as of React v15.5" reads. But I don't have much preference.

[aweary]

What about something like:

React.PropTypes was extracted into it a standalone package in the React v15.5 release.

This way it's clear that it's a standalone implementation and not just being moved into some other package ("different package")

[nhunzaker]

@aweary I can get behind that, 👍

[rscharfer]

works for me :)

[rscharfer]

I can close the pull request, right?

[nhunzaker]

@rscharfer If you want to go with "React.PropTypes was extracted into it a standalone package in the React v15.5 release.", I'd be happy to merge that.

[bvaughn]

Thank you for filing this PR!

I'm sorry to be the bearer of bad news, but the documentation and source code for reactjs.org now lives in a different repository: reactjs/reactjs.org. (For more info on why we made this move, see issue #11075.)

Would you be willing to re-open this PR on the new repo? I promise we'll review it quickly!