-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove functions marked as undocumented and unused #10096
Remove functions marked as undocumented and unused #10096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @BenBrostoff! While these APIs are undocumented they were still technically accessible as part of the public API. Since there's still a chance these are being used we might want to deprecate them before fully removing them.
cc @gaearon what do you think?
I wouldn't mind deprecating but we need to make sure they're not used by Enzyme. |
8088c3f
to
82c64a4
Compare
@gaearon we only import and re-export |
Mind sending a PR to Enzyme to stop importing it? |
@gaearon opened at enzymejs/enzyme#1023, though the rewrite doesn't contain this import/export so it might just be removed when that's merged instead. |
@gaearon the export will be removed in the next major release when enzymejs/enzyme#1007 is merged and released. |
I deleted them in the end. |
Hey @gaearon - saw you added these TODOs in this commit about 8 months ago. Figured I'd open a PR if this can now be completed.