Cannot run tests correctly on Windows #8737
Comments
|
@jddxf do you want to submit a PR with fixes for these? |
|
Sure,I've already done this.Something is wrong with my git.I can't fetch or push. |
|
Fixed here #8747 .Also I wonder whether issues of this sort should be opened since they're not related to the functionality.Maybe a PR would be enough? |
gaearon
pushed a commit
that referenced
this issue
Jan 12, 2017
* fix failed tests on Windows #8737 * Use regexp literal instead of `RegExp` constructor so that we don't need to bother with escaping special character like `\` and `.`. Note that by removing the path separator in regexp, I've relaxed the matching condition a little.Since there's little chance we have files like `XXXReact.d.ts`,it should not matter.
|
If you can fix it, just send a PR, but when not sure or don’t have time, please file an issue so somebody else could do it. Thanks for jumping on this. |
|
got it.thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some issues in test code failing the tests on Windows.
Invalid regular expression
https://github.com/facebook/react/blob/master/scripts/jest/ts-preprocessor.js#L30-L32
It would be an invalid regexp just like /\(a)/.
Invalid arguments passed to
child_process.spawnhttps://github.com/facebook/react/blob/master/src/isomorphic/modern/class/__tests__/ReactClassEquivalence-test.js#L34-L45
This issue is similar to "npm run lint" fails on Windows #8021
The text was updated successfully, but these errors were encountered: